Finish the "Show sidebar on hover" PR #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shown when hovered over
dosubot
bot
added
size:XS
|
Does it still work? |
What do you mean? I missed that the default css hover was applied to the sidebar and toolbar. I thought it only had zen-has-hover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4792 I made the
zen-has-hoverproperty be added to the sidebar and toolbar only ifzen.view.compact.show-sidebar-and-toolbar-on-hoveris true.There was an oversight, though. The animation for the sidebar and toolbar was being triggered both by
zen-has-hoverandhover, like thisThis meant that
:hoverwas overriding[zen-has-hover].This PR makes both bars depend on
zen-has-hoverand removeshover.I have tested this with the Browser Toolbox and it works perfectly :)