Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): handle IME via controlled input onChange override #588

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix(combobox): handle IME via controlled input onChange override #588

merged 3 commits into from
Sep 21, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Sep 20, 2023

Description

The Downshift useCombobox hook currently has an issue that prevents IME from entering expected values in a controlled combobox. This workaround re-invokes onChange with the correct composed input value. The majority of the PR is the introduction of a new "IME" pattern storybook demo so that future updates can be tested with IME without interference from useArgs.

Before

before

After

after

Detail

downshift-js/downshift#1452

Checklist

  • 🌐 demo is up-to-date (yarn start)
  • 💂‍♂️ includes new unit tests
  • ♿ tested for WCAG 2.1 AA compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from a team as a code owner September 20, 2023 21:40
@coveralls
Copy link

coveralls commented Sep 20, 2023 •
edited
Loading

Coverage Status

coverage: 96.102% (-0.04%) from 96.139% when pulling 6a2e181 on jzempel/combobox-ime into 014474b on main.

geotrev
geotrev approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jzempel jzempel merged commit 569e785 into main Sep 21, 2023
@jzempel jzempel deleted the jzempel/combobox-ime branch September 21, 2023 14:52
@jzempel jzempel mentioned this pull request Sep 21, 2023
Merged
@cheton cheton mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geotrev geotrev geotrev approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzempel @coveralls @geotrev @zendesk-garden