Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #88

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fixes #88

merged 2 commits into from
Nov 13, 2023

Conversation

bryanburgers
Copy link
Contributor

@bryanburgers bryanburgers commented Nov 13, 2023 •
edited
Loading

@bryanburgers
Allow maps with bools as keys
9f0784d 
Allow serializing to and deserializing from maps that have booleans as
their keys, like `HashMap<bool, String>`, etc.

Fixes #80
@bryanburgers
Fix for aws-sdk 0.35 interface change
48eed0a 
aws-sdk-dynamo's ScanOutput and QueryOutput changed slightly in the most
recent release: 0.35.

Previously

    pub fn items(&self) -> Option<&[HashMap<String, AttributeValue>]>

Now

    pub fn items(&self) -> &[HashMap<String, AttributeValue>]

While this doesn't affect serde_dynamo directly, we do have a bunch of
doc comments that use `result.items()`. Update those so that the tests
pass again.

This was missed on the 0.35 PR because tests had been failing for
another reason (#80) for a while, so I didn't even bother looking at the
failing tests.
@bryanburgers bryanburgers merged commit 5a529db into main Nov 13, 2023
6 checks passed
@bryanburgers bryanburgers deleted the fixes branch November 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test on serde_json round-trip
1 participant
@bryanburgers