Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aws-sdk-dynamodb 1 #97

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

vmaerten
Copy link
Contributor

No description provided.

@dcormier
Copy link
Contributor

Should this feature perhaps be "aws-sdk-dynamodb+1", with aws-sdk-dynamodb crate version 1 being enabled? This should allow the dependant crate to use any minor revision of aws-sdk-dynamodb v1.

@vmaerten
Copy link
Contributor Author

Can be good, but i'm not sure they won't change anything in the SDK
What do you thing @bryanburgers ?

@vmaerten
Copy link
Contributor Author

I've updated to match create version 1

They also did like that in Opensearch rs (https://github.com/opensearch-project/opensearch-rs/blob/main/opensearch/Cargo.toml#L43-L46)

@vmaerten vmaerten changed the title Support for aws-sdk-dynamodb 1.2 Support for aws-sdk-dynamodb 1 Nov 27, 2023
@bryanburgers
Copy link
Contributor

Yeah. I strongly support doing just 1, not 1.2. Then we can get off of this version treadmill!

I’m also strongly considering supporting aws-sdk-DynamoDB 1 without a feature flag.

  • aws-sdk-dynamodb is stable
  • rusoto is dead
  • aws-lambda-events uses serde_dynamo directly

Given those three, it seems like serde_dynamo could just be stable at this point?

@bryanburgers
Copy link
Contributor

But I’ll at least make a release with the feature flag first. And then decide what to do.

@bryanburgers bryanburgers merged commit 29ea0bf into zenlist:main Nov 27, 2023
@bryanburgers
Copy link
Contributor

Released in version 4.2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants