-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify header across views #598
Conversation
Charts still looks off, but can fix in another PR where we add headers describing what view you are in probably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like it overall! Some small things:
- Can we make the project/report name a bit bigger? Important to know and not visually prominent at all now. More like it was before.
- How's the link icon useful on project home? Don't think we need it there.
- One thing that was really nice before was that the project name started right with the metadata panel. Probably not possible if we want to keep the full logo, though, which I find nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace the explore button as well? Is the positioning even right for it? |
I switched them in both, always at the far left now so consistent everywhere |
Question mark left? One thing that I still find confusing about that is that the question mark is not related to the project as is the user icon whereas the gear is, but the gear is between the two. I think question mark next to user might make more sense? |
hmm maybe far right? but user far right is most typical right |
Yes I think user makes sense. Why do you want to have the question mark on the left? |
always same place. but I guess it's always same place next to the user icon or sign in stuff... can move it back I think you're right makes more sense |
Maybe the settings button should be close to the project content anyway. Like next to the heart or something. Then we have context-dependent stuff left, independent right. |
Description
Fix ZEN-429