Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify header across views #598

Merged
merged 5 commits into from
Dec 27, 2023
Merged

feat: unify header across views #598

merged 5 commits into from
Dec 27, 2023

Conversation

cabreraalex
Copy link
Member

Description

Fix ZEN-429

image

Copy link

linear bot commented Dec 22, 2023

@cabreraalex
Copy link
Member Author

Charts still looks off, but can fix in another PR where we add headers describing what view you are in probably.

Copy link
Member

@Sparkier Sparkier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like it overall! Some small things:

  • Can we make the project/report name a bit bigger? Important to know and not visually prominent at all now. More like it was before.
  • How's the link icon useful on project home? Don't think we need it there.
  • One thing that was really nice before was that the project name started right with the metadata panel. Probably not possible if we want to keep the full logo, though, which I find nice.

@cabreraalex
Copy link
Member Author

Updated the font, agreed it looks nice.

I like the link button on projects b/c it removes the extra state for a clean URL I find useful. can go either way though.

Yeah I think worth having the consistent logo on all screens.

image

Copy link
Member

@Sparkier Sparkier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the button on projects, too. I was talking about home, though.

image

@cabreraalex
Copy link
Member Author

A couple of changes:

  • Made settings a gear icon to be consistent
  • fixed mobile view with long titles
  • Fixed tests

image

@Sparkier
Copy link
Member

A couple of changes:

  • Made settings a gear icon to be consistent
  • fixed mobile view with long titles
  • Fixed tests

image

Gear looks off-center in your screenshot.

@cabreraalex
Copy link
Member Author

Like the button on projects, too. I was talking about home, though.

image

oh LOL that should definitely go

@Sparkier
Copy link
Member

A couple of changes:

  • Made settings a gear icon to be consistent
  • fixed mobile view with long titles
  • Fixed tests

image

Gear looks off-center in your screenshot.

Also would probably swap with question mark for consistency with home.

@Sparkier
Copy link
Member

Should we replace the explore button as well? Is the positioning even right for it?

@cabreraalex
Copy link
Member Author

A couple of changes:

  • Made settings a gear icon to be consistent
  • fixed mobile view with long titles
  • Fixed tests

image

Gear looks off-center in your screenshot.

Also would probably swap with question mark for consistency with home.

I switched them in both, always at the far left now so consistent everywhere

@Sparkier
Copy link
Member

Question mark left? One thing that I still find confusing about that is that the question mark is not related to the project as is the user icon whereas the gear is, but the gear is between the two. I think question mark next to user might make more sense?

@cabreraalex
Copy link
Member Author

hmm maybe far right? but user far right is most typical right

@Sparkier
Copy link
Member

Yes I think user makes sense. Why do you want to have the question mark on the left?

@cabreraalex
Copy link
Member Author

always same place. but I guess it's always same place next to the user icon or sign in stuff... can move it back I think you're right makes more sense

@Sparkier
Copy link
Member

Sparkier commented Dec 22, 2023

Maybe the settings button should be close to the project content anyway. Like next to the heart or something. Then we have context-dependent stuff left, independent right.

@cabreraalex
Copy link
Member Author

Okay I moved the help to always be on the far left of the right side, made the most sense when using it. Also changed the cog icon

image

@cabreraalex cabreraalex requested a review from Sparkier December 27, 2023 18:36
@Sparkier Sparkier merged commit 06954d2 into main Dec 27, 2023
5 checks passed
@Sparkier Sparkier deleted the ac-header-uni branch December 27, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants