Bluetooth: TBS: Fix NULL pointer issue in v3.7 #84149
Open
+35
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we read an empty GATT characteristic that should contain a string value, then we provide the empty string, instead of NULL, to be true to the API. Signed-off-by: Emil Gydesen <[email protected]>
aescolar
reviewed
Jan 17, 2025
The supported URI list may be empty which the sample did not properly support. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
3_7_tbs_fixes
branch
from
9aa80b1 to
f34b587
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
jthm-ot,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr,
sjanc and
Vudentz
jhedberg
reviewed
Jan 17, 2025
| @@ -139,6 +140,11 @@ int ccp_originate_call(void) | |||
| int err; | |||
| char uri[CONFIG_BT_TBS_MAX_URI_LENGTH]; | |||
|
|
|||
| if (strlen(remote_uri) == 0U) { | |||
There was a problem hiding this comment.
Quite minor, but when you just want to know if the string is empty or not, strlen() is rather overkill since you end up iterating the entire string every time when you're actually only interested in the first byte. if (str[0] == '\0') is not the prettiest thing either, so it could be nice to have a helper for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84148