Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and publish wheel #103

Closed

Conversation

dimbleby
Copy link

No description provided.

@dimbleby dimbleby force-pushed the build-and-publish-wheel branch from 9cb5b74 to 0d0f8bf Compare January 25, 2025 20:06
@zeroSteiner
Copy link
Owner

Is there some kind of advantage to the wheel over the source distribution for this package? I'm not familiar with this build package that's used now so I'll need to look into it.

@dimbleby
Copy link
Author

dimbleby commented Jan 26, 2025

the way packaging works in python is that every installation is from a wheel. By publishing only a source distribution you are requiring all of your users to build the wheel: which is slower, and has some non-zero chance of going wrong.

Better for package owners to build and publish wheels once and for all

Direct invocation of setup.py is considered deprecated, the build package is a commonly recommended replacement eg https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

@zeroSteiner
Copy link
Owner

I appreciate your interest in rule-engine and bringing this to my attention. However, I've decided that I will not be merging this PR.

I actually generate the ci.yml file you edited from a template I have that I share with my other projects. Until there's a need for me to adjust how I package and release my builds, I'd prefer to keep them all uniform so that I can more easily troubleshoot and maintain them. I'm also hesitant to add another dependency when there's not a clear issue that it solves.

@dimbleby
Copy link
Author

dimbleby commented Jan 26, 2025

To be honest my interest is more in the broader ecosystem then in this project specifically.

Per the advice that I linked

  • your current use of setup.py is deprecated (and will eventually break)
  • it is just better to publish wheels than not

So I hope that at some point you will update your template to Do The Right Thing!

But it would be a stretch to call it urgent. All the best either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants