Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by clang-tidy #178

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Conversation

pepone
Copy link
Member

@pepone pepone commented Mar 9, 2023

This PR updates C++11 demos, to fix warnings reported by clang-tidy, the majority are about const correctness, for places where we forget to declare a variable const. There are a few other things like std::move usage and some other minor issues.

see also #146

@pepone pepone requested review from externl and bernardnormier March 9, 2023 16:37
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cpp11/Chat/server/ChatSessionI.h Outdated Show resolved Hide resolved
cpp98/IceGrid/customLocator/Client.cpp Show resolved Hide resolved
Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pepone pepone merged commit 9551789 into zeroc-ice:3.7.9-rc Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants