Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ build fixes #207

Merged
merged 18 commits into from
May 29, 2024
Merged

C++ build fixes #207

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
986cfe0
C++ build fixes
externl May 28, 2024
7409f29
Fixe
externl May 28, 2024
0466885
CI cleanup
externl May 28, 2024
80b1236
Another CI fix
externl May 28, 2024
a4b1869
Review fixes
externl May 28, 2024
72f29df
More review fixes
externl May 28, 2024
bffd443
Remove Ice::registerIceSSL
externl May 28, 2024
be0c1c5
Fix demo ci build
externl May 28, 2024
ea65f9d
Build fixes
externl May 28, 2024
6ed7add
Windows fixes
externl May 28, 2024
9208c1b
Build fixes
externl May 29, 2024
30f5c7e
Escape windows demo sln name
externl May 29, 2024
4f91753
Delete qt demo
externl May 29, 2024
b7091fa
Disable Windows CI
externl May 29, 2024
36caa5b
Review fixes
externl May 29, 2024
a618b1d
Fix
externl May 29, 2024
90efcb2
Review fixes
externl May 29, 2024
e7469c1
review fix
externl May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/Chat/client/Client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ run(shared_ptr<Ice::Communicator> communicator)
// provided by the router
Ice::Identity id{Ice::generateUUID(), router->getCategoryForClient()};

Chat::ChatRoomCallbackPrx callbackPrx = adapter->add(make_shared<ChatRoomCallbackI>(), id);
auto callbackPrx = Chat::ChatRoomCallbackPrx{adapter->add(make_shared<ChatRoomCallbackI>(), id)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

Chat::ChatRoomCallbackPrx callbackPrx{adapter->add(make_shared<ChatRoomCallbackI>(), id)};


// Set the callback proxy on the session
session->setCallback(callbackPrx);
Expand Down
Loading