Use the 'New' Metadata Validator for slice2swift
#3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+656
to
+657
| void | ||
| SwiftGenerator::validateSwiftModuleMappings(const UnitPtr& unit) |
There was a problem hiding this comment.
All this code was just moved out of MetadataValidator::visitUnit into a new static function.
I didn't change anything else about it.
externl
approved these changes
Feb 10, 2025
bernardnormier
approved these changes
Feb 10, 2025
| }; | ||
| knownMetadata.emplace("swift:class-resolver-prefix", classResolverPrefixInfo); | ||
|
|
||
| // "swift:inherits" |
There was a problem hiding this comment.
We should drop swift:inherits.
There was a problem hiding this comment.
After this is merged I'll have a follow up PR to drop swift:inherits and loosen the swift:module check.
I think that should be all the issues around Swift metadata.
| MetadataInfo moduleInfo = { | ||
| .validOn = {typeid(Module)}, | ||
| // Even though it's really 'module:prefix' the validator sees this as a single argument since there's no commas. | ||
| .acceptedArgumentKind = MetadataArgumentKind::SingleArgument, |
There was a problem hiding this comment.
We should drop the MetadataArgumentKind::MultipleArguments (?) option since we don't use it for any Slice metadata except support warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
slice2swiftto use the new metadata validator built intolibSlice.It is the last language to be switched, and after this PR is merged, I will finally consider issue #117 fixed.