refactor: make sure to select chains mutual exclusively

zerodevapp · Mar 1, 2024 · 604747f · 604747f
1 parent 1df6dad
commit 604747f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/src/command/index.ts b/src/command/index.ts
@@ -124,7 +124,7 @@ program
         "-s, --salt <salt>",
         "salt to be used for CREATE2. This can be a full 32-byte hex string or a shorter numeric representation that will be converted to a 32-byte hex string."
     )
-    .option("-t, --testnet-all", "select all testnets", true)
+    .option("-t, --testnet-all", "select all testnets", false)
     .option("-m, --mainnet-all", "select all mainnets", false)
     .option("-a, --all-networks", "select all networks", false)
     .option(

diff --git a/src/utils/validate.ts b/src/utils/validate.ts
@@ -76,26 +76,26 @@ export const processAndValidateChains = (
     options: CommandOptions
 ): Chain[] => {
     const supportedChains = getSupportedChains()
-    if (
-        chainOption !== undefined &&
-        (options.testnetAll || options.mainnetAll || options.allNetworks)
-    ) {
-        console.error("Error: Cannot use -c option with -t, -m, -a options")
-        process.exit(1)
-    }
-
-    if (options.testnetAll && options.mainnetAll) {
-        console.error("Error: Cannot use -t and -m options together")
-        process.exit(1)
-    }
-
-    if (options.testnetAll && options.allNetworks) {
-        console.error("Error: Cannot use -t and -a options together")
+    // Check for mutually exclusive options
+    const exclusiveOptions = [
+        chainOption !== undefined,
+        options.testnetAll,
+        options.mainnetAll,
+        options.allNetworks
+    ]
+    const selectedOptionsCount = exclusiveOptions.filter(
+        (isSelected) => isSelected
+    ).length
+
+    if (selectedOptionsCount === 0) {
+        console.error(
+            "Error: At least one of -c, -t, -m, -a options must be specified"
+        )
         process.exit(1)
-    }
-
-    if (options.mainnetAll && options.allNetworks) {
-        console.error("Error: Cannot use -m and -a options together")
+    } else if (selectedOptionsCount > 1) {
+        console.error(
+            "Error: Options -c, -t, -m, -a are mutually exclusive and cannot be used together"
+        )
         process.exit(1)
     }