Refactor all stores to remove the simplesessions dependency and adhere #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the new `simplesessions/v2` interface methods. This is a breaking
change.`
This commit also refactors securestore and changes its behaviour.
This store is peculiar because it does not actually have a persistent
backend store and instead uses the session/cookie ID string (value)
itself as the encoded store. The older version thus relied on Session{}
to write the cookie to the frontend, which is not ideal.
This version removes the dependency and leaves the actual cookie writing
to the implementer. This commit introduces a new `Flush()` method that
returns the encoded values set using Set(), which the implementer can
then write to a cookie externally (with a `Session.WriteCookie()`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the new
simplesessions/v2interface methods. This is a breaking change.`This commit also refactors securestore and changes its behaviour.
This store is peculiar because it does not actually have a persistent backend store and instead uses the session/cookie ID string (value) itself as the encoded store. The older version thus relied on Session{} to write the cookie to the frontend, which is not ideal.
This version removes the dependency and leaves the actual cookie writing to the implementer. This commit introduces a new
Flush()method that returns the encoded values set using Set(), which the implementer can then write to a cookie externally (with aSession.WriteCookie()).