ci: download pack after checkout + enable node 10

zeromq · Oct 26, 2024 · 9b8f85f · 9b8f85f
1 parent 1257c49
commit 9b8f85f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -236,17 +236,15 @@ jobs:
         os:
           - ubuntu-24.04
           - windows-2022
-          - macos-14
           - macos-13
         node-version:
-          # - 10
+          - 10
           - 22
-    steps:
-      - name: Download Pack
-        uses: actions/download-artifact@v4
-        with:
-          name: pack
 
+        include:
+          - os: macos-14
+            node-version: 22
+    steps:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
@@ -276,5 +274,10 @@ jobs:
 
       - uses: actions/checkout@v4
 
+      - name: Download Pack
+        uses: actions/download-artifact@v4
+        with:
+          name: pack
+
       - name: Smoke Test
         run: bash ./script/smoke-test.bash
diff --git a/script/smoke-test.bash b/script/smoke-test.bash
@@ -6,7 +6,7 @@ echo "Pack zeromq.js if needed"
 version=$(node -e 'console.log(require("./package.json").version)')
 pack_name="zeromq-${version}.tgz"
 echo "${pack_name}"
-test -f "${pack_name}" || ls -R
+test -f "${pack_name}" || npm pack
 
 init_smoke_test() {
     local pm=$1
@@ -15,8 +15,8 @@ init_smoke_test() {
     rm -rf "./smoke-test-${pm}"
     mkdir "./smoke-test-${pm}"
     cd "./smoke-test-${pm}"
-    npm init -q --init-module "smoke-test-${pm}" -y
-    npm pkg set dependencies.zeromq="file:../${pack_name}" || (jq '.dependencies.zeromq = "file:../${pack_name}"' package.json >temp.json && mv temp.json package.json)
+    npm init -y
+    npm pkg set dependencies.zeromq="file:../${pack_name}" || (jq ".dependencies.zeromq = \"file:../${pack_name}\"" package.json >temp.json && mv temp.json package.json)
 }
 
 package_managers=(npm pnpm yarn)