-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo fmt #48
base: master
Are you sure you want to change the base?
Cargo fmt #48
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
✅ Deploy Preview for thriving-beignet-855860 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Unfortunately I'm not sure I can accept this PR at the moment. rustfmt has done some pretty painful things to some of the code here, particularly in and around the type solver. Perhaps in time when things are refactored and made cleaner a format pass would be a bit less painful to deal with, but for now there's too much that becomes actively harder to understand because of it :\ As a random example of something that goes from being neat and easy to reason about to simply being opaque visual noise: |
I see where you're coming from... but wouldn't the other way round also be a sensible way? Format the codebase, which easily shows the bits that are refactor-worthy (like the bit you from your screenshot) and then refactor them? 😆 |
Refactoring the type checker would be... A mammoth task. I absolutely want to do it at some point, but not before I figure out a formalisation for things like effect type inference. |
Hi!
As briefly discussed on mastodon, here goes my first patchset.
This PR does only run
cargo-fmt
on the codebase, as a first step. A later PR will introduce cargo-fmt checking in github actions.