-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use threshold-network tss-lib fork #28
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Write at 0x00c000288110 by goroutine 380: gitlab.com/thorchain/tss/go-tss/keysign.(*notifier).updateUnset() /home/runner/work/go-tss/go-tss/keysign/notifier.go:62 +0xe4 gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).createOrUpdateNotifier() /home/runner/work/go-tss/go-tss/keysign/signature_notifier.go:252 +0x2fd gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).handleStream() /home/runner/work/go-tss/go-tss/keysign/signature_notifier.go:136 +0xa71 gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).handleStream-fm() <autogenerated>:1 +0x4d github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).SetStreamHandler.func1() /home/runner/go/pkg/mod/github.com/zeta-chain/[email protected]/p2p/host/basic/basic_host.go:580 +0x86 github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).newStreamHandler.func1() /home/runner/go/pkg/mod/github.com/zeta-chain/[email protected]/p2p/host/basic/basic_host.go:421 +0x74 Previous read at 0x00c000288110 by goroutine 208: gitlab.com/thorchain/tss/go-tss/keysign.(*notifier).readyToProcess() /home/runner/work/go-tss/go-tss/keysign/notifier.go:51 +0xd46 gitlab.com/thorchain/tss/go-tss/keysign.TestSignatureNotifierBroadcastFirst() /home/runner/work/go-tss/go-tss/keysign/signature_notifier_test.go:162 +0xdb8 testing.tRunner() /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1576 +0x216 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1629 +0x47
* ECDSA & EDDSA working w/ bnb-chain/tss-lib v1.3.5 https://gitlab.com/thorchain/tss/go-tss/-/merge_requests/264 * use github.com/btcsuite/btcd/btcec/v2 * Use threshold-network tss-lib fork (#28) * Use threshold-network tss-lib fork * Add lock in notifier to avoid data race Write at 0x00c000288110 by goroutine 380: gitlab.com/thorchain/tss/go-tss/keysign.(*notifier).updateUnset() /home/runner/work/go-tss/go-tss/keysign/notifier.go:62 +0xe4 gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).createOrUpdateNotifier() /home/runner/work/go-tss/go-tss/keysign/signature_notifier.go:252 +0x2fd gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).handleStream() /home/runner/work/go-tss/go-tss/keysign/signature_notifier.go:136 +0xa71 gitlab.com/thorchain/tss/go-tss/keysign.(*SignatureNotifier).handleStream-fm() <autogenerated>:1 +0x4d github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).SetStreamHandler.func1() /home/runner/go/pkg/mod/github.com/zeta-chain/[email protected]/p2p/host/basic/basic_host.go:580 +0x86 github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).newStreamHandler.func1() /home/runner/go/pkg/mod/github.com/zeta-chain/[email protected]/p2p/host/basic/basic_host.go:421 +0x74 Previous read at 0x00c000288110 by goroutine 208: gitlab.com/thorchain/tss/go-tss/keysign.(*notifier).readyToProcess() /home/runner/work/go-tss/go-tss/keysign/notifier.go:51 +0xd46 gitlab.com/thorchain/tss/go-tss/keysign.TestSignatureNotifierBroadcastFirst() /home/runner/work/go-tss/go-tss/keysign/signature_notifier_test.go:162 +0xdb8 testing.tRunner() /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1576 +0x216 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1629 +0x47 --------- Co-authored-by: sumamu <[email protected]>
No description provided.