Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caller might be undefined, avoid type error #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bit
Copy link

@bit bit commented Dec 4, 2024

Uncaught TypeError: caller is undefined
callInfo TargetInfo.jsx:65
value TargetInfo.jsx:62
TargetInfo.jsx:65:20

Uncaught TypeError: caller is undefined
    callInfo TargetInfo.jsx:65
    value TargetInfo.jsx:62
TargetInfo.jsx:65:20
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've found the same bug that I found when I deployed your recent changes earlier today. But it's odd because caller should never be undefined. And if the caller is undefined, fixing it just here won't be enough.

Have you been able to reproduce this locally, and found that this fix solves the problem without introducing any new problems?

It seems to me like this was happening because of some server-side error when loading the memberships of the current user, when that user has a very large number of memberships (such as a top-level admin). I verified that it wasn't happening for more normal users, such as non-admin callers or lower-level admins.

@bit
Copy link
Author

bit commented Dec 4, 2024

I have never seen this error on the local test system, only in production and not right after the new deployment but once many people started calling tonight. So this might need be related to server side issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants