This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Hotfix/service locator aware interface #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2016 23:06
…ce. Not as exact but close enough for the administrator
…e locator in the AbstractAutodiscoveryModel
…lasses by default
|
@TomHAnderson Will go through your PR shortly. Meanwhile, you may want to check the couple of CS issues ;) |
|
Thanks @jguittard The CS issues were not from the new code and the standard has been changed then corrected two small CS issues. |
| @@ -77,10 +47,8 @@ public function fetch($id) | |||
| */ | |||
| public function fetchAll($params = []) | |||
| { | |||
| $modules = $this->getServiceLocator()->get('ModuleManager'); | |||
| $loaded = $modules->getLoadedModules(false); | |||
There was a problem hiding this comment.
I would inject the loaded variable through the DoctrineAdapterResource ctor, thus not relying on class_exists methods. @TomHAnderson what do you say?
There was a problem hiding this comment.
Yes, that's fine. I'll make it so.
|
Should this PR be merged I need a new release so I can develop zf-apigility-doctrine as the AbstractAutodiscoveryModel is extended in that repository. |
… on an injected service locator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ServiceLocatorAwareInterface requirement of this module. It also corrects a unit test where invokable classes are expected to exist on the zend-hydrator HydratorPluginManager but this plugin manager has none.
#341 (comment)
#339
#332