Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PDFs, add labels #75

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Upgrade PDFs, add labels #75

merged 2 commits into from
Apr 12, 2024

Conversation

jonas-eschle
Copy link
Contributor

@jonas-eschle jonas-eschle commented Apr 12, 2024

Minor cleanup to upgrade to zfit 0.20.0

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

m = params["m"]
t = params["t"]
n = params["n"]
x = x[0]
return tsallis_pdf_func(x=x, m=m, t=t, n=n)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI @ikrommyd , that's what 0.20.0 has in it: the params are now given as an argument (therefore, the method could be static!) and the x can now be accessed via the "axis" (i.e. the x is a Data object, but indexing with 0 returns the 0th axis)

The whole PR is just a chore, an upgrade of internals

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I see this change only in zfit_physics and not in zfit for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially, the zfit pdfs have all labels by now (which is needed in the plotting) and some also get the params. It really doesn't change a lot, it's more about the API and how it looks for the user, and we're able to make them static. zfit.supports() provides the magic :)

@jonas-eschle jonas-eschle merged commit ed74592 into develop Apr 12, 2024
10 of 12 checks passed
@jonas-eschle jonas-eschle deleted the fix/cleanup_pdfs branch April 12, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants