Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghost placeholders for missing properties #27

Open
fmalina opened this issue Mar 25, 2019 · 6 comments
Open

Add ghost placeholders for missing properties #27

fmalina opened this issue Mar 25, 2019 · 6 comments

Comments

@fmalina
Copy link

fmalina commented Mar 25, 2019

List on the right shows textual information about missing properties in one column or another.

It would be better if this data was used to put ghost placeholders of the same height as the information present where the information is missing. Textual warnings would then not be needed.

This would aid comparison as equal and equivalent information would end up side by side. Diffmerge is an example of a comparison tool that does this well.

@fmalina fmalina changed the title Add visual placeholders for missing data Add ghost placeholders for missing properties Mar 25, 2019
@zgrossbart
Copy link
Owner

Thank you for the feature request, but I'm not sure what you mean. Any chance you have a screenshot or a drawing that shows what you're looking for here?

@fmalina
Copy link
Author

fmalina commented Mar 25, 2019

ghost placeholder

@fmalina
Copy link
Author

fmalina commented Mar 25, 2019

Empty lines are inserted in place of missing information on either side to vertically align matching information for easier comparison.

@fmalina fmalina mentioned this issue Mar 25, 2019
@zgrossbart
Copy link
Owner

I've been looking into this and I'm having two design issues. The first is that we would still need the callouts on the right explaining what the difference was. Just have the space doesn't explain why they are different.

The second issue is that a missing property could represent an object that was very long. That could cause a ghost line that was pages long.

There are also some other edge cases here like missing array properties. If there was an array with 100 properties on the left side and one property on the right side it wouldn't be useful to show 99 empty lines.

@fmalina
Copy link
Author

fmalina commented Mar 26, 2019

Sounds reasonable. These ghost lines need a good background pattern.

@fmalina
Copy link
Author

fmalina commented Aug 29, 2020

I've just recently returned to jsondiff recommending it to a colleague, but thinking about the worries you mentioned I am not finding them as relevant, never been an issue for me while using diffmerge. I don't have the code to make this happen ATM, so I'll shush now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants