Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated styles #28

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Updated styles #28

merged 2 commits into from
Mar 25, 2019

Conversation

fmalina
Copy link

@fmalina fmalina commented Mar 25, 2019

Fixes #26

@zgrossbart
Copy link
Owner

Thank you so much for this update. I think the new colors work really well on the compare page. If you can make the text in the upper right of the main page align with the right-side compare field then I'd be really happy to take in this change.

Screen Shot 2019-03-25 at 8 42 01 AM

@zgrossbart
Copy link
Owner

I have a couple of small spacing tweaks: #29

@fmalina
Copy link
Author

fmalina commented Mar 25, 2019

Looks great!

@zgrossbart
Copy link
Owner

Sounds good. Would you like to merge my PR into yours, or would you like me to merge your PR and then make changes on top of it?

@zgrossbart zgrossbart merged commit dded50a into zgrossbart:master Mar 25, 2019
@fmalina
Copy link
Author

fmalina commented Mar 25, 2019

I don't have a preference. But I'd love if you could make this live and look at #27

@zgrossbart
Copy link
Owner

I have merged it in and made my changes on top of it. Let me do a little more testing and I'll get it deployed soon.

I need to look more at #27. I'm not sure about how that will work for larger JSON documents. Let me think about it a bit more.

@zgrossbart
Copy link
Owner

This change is now deployed. Thanks again for the awesome update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants