Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupts the global namespace, hard to inject multiple instances in page #30

Open
nitinsurana opened this issue May 4, 2019 · 3 comments

Comments

@nitinsurana
Copy link

No description provided.

@zgrossbart
Copy link
Owner

Thank you for the bug, but I'm not sure I understand. JSONDiff is an application and not a library. It's not meant be injected multiple times in a page. Can you please tell me more about what you're trying to do.

@nitinsurana
Copy link
Author

Sure, I'm trying to use this application in a custom UI as a sub-component, but since it corrupts the global namespace; it's hard to start new instance of it with different dataset.
I've forked it and hopefully, will turn it into a library and if you're open to it, possibly send a PR back.

@nitinsurana
Copy link
Author

Maybe just adding a parent capability, to not look for elements all across the page should work out fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants