Exposed as a function so that multiple instances of it can be created wi… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a different parent and do not interfere with each others' calcuation. It also allows to re-initialize the UI with new dataset without refreshing the page All qunit tests are working fine.
nitinsurana
changed the title
|
Thank you for this. I'll take a closer look tomorrow. Do you think this should get merged into the master branch for the jsondiff.com website, or stay a separate project? |
…e not related to comparison
|
It's a lot of change :-| I'm not sure, whether we should merge it or not. It's a call you'd have to take. As far as functionality is concerned, jsondiff.com would remain unaffected with these changes. |
|
After giving it another thought - there's still a lot of coupling between UI and diffModel. Let's not merge at this point. |
|
I agree. I'm going to close this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th a different parent and do not interfere with each others' calcuation.
It also allows to re-initialize the UI with new dataset without refreshing the page
All qunit tests are working fine.
Fixes #30