Made output adapter static

zhendrikse · Nov 7, 2023 · f3267e9 · f3267e9
1 parent 331fedc
commit f3267e9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/kata-solutions/countries-kata/countries-kata-javascript/spec/CountryList_spec.js b/kata-solutions/countries-kata/countries-kata-javascript/spec/CountryList_spec.js
@@ -29,7 +29,7 @@ class CountriesInputAdapterStub {
 }
 
 class MockCountriesOutputAdapter {
-  write(countrList) {
+  static write(countrList) {
     let csvContent = "";
 
     countrList.forEach(function(rowArray) {
@@ -48,7 +48,7 @@ describe('A list without countries (empty list)', () => {
   let countryList;
 
   beforeEach(async () => {
-    countryList = await CountryList.create_instance(EmptyCountriesInputAdapterStub, new MockCountriesOutputAdapter());
+    countryList = await CountryList.create_instance(EmptyCountriesInputAdapterStub, MockCountriesOutputAdapter);
   });
 
   it('should sort the empty list', () => {
@@ -69,7 +69,7 @@ describe('A list with countries', () => {
   let countryList;
 
   beforeEach(async () => {
-    countryList = await CountryList.create_instance(CountriesInputAdapterStub, new MockCountriesOutputAdapter());
+    countryList = await CountryList.create_instance(CountriesInputAdapterStub, MockCountriesOutputAdapter);
   });
 
 

diff --git a/kata-solutions/countries-kata/countries-kata-javascript/src/CountryList.js b/kata-solutions/countries-kata/countries-kata-javascript/src/CountryList.js
@@ -10,7 +10,7 @@ class CountryList {
     this.outputPort = outputPort;
   }
 
-  static async create_instance(inputPort = RestCountriesInputAdapter, outputPort = new CsvOutputAdapter()) {
+  static async create_instance(inputPort = RestCountriesInputAdapter, outputPort = CsvOutputAdapter) {
     return new CountryList(await inputPort.instance(), outputPort);
   }
 

diff --git a/kata-solutions/countries-kata/countries-kata-javascript/src/CsvOutputAdapter.js b/kata-solutions/countries-kata/countries-kata-javascript/src/CsvOutputAdapter.js
@@ -1,7 +1,7 @@
 const fs = require('fs');
 
 class CsvOutputAdapter {
-    write(countrList) {
+    static write(countrList) {
       let csvContent = "";
 
       countrList.forEach(function (rowArray) {

diff --git a/tdd-katas/countries-kata/countries-kata-javascript/README.md b/tdd-katas/countries-kata/countries-kata-javascript/README.md
@@ -328,7 +328,7 @@ constructor(inputPort, outputPort) {
   this.outputPort = outputPort;
 }
 
-static async create_instance(inputPort = RestCountriesInputAdapter, outputPort = new CsvOutputAdapter()) {
+static async create_instance(inputPort = RestCountriesInputAdapter, outputPort = CsvOutputAdapter {
   return new CountryList(await inputPort.instance(), outputPort);
 }
 ```
@@ -368,7 +368,7 @@ an empty list of countries.
     let countryList;
 
     beforeEach(async () => {
-      countryList = await CountryList.create_instance(EmptyCountriesInputAdapterStub, new MockCountriesOutputAdapter());
+      countryList = await CountryList.create_instance(EmptyCountriesInputAdapterStub, MockCountriesOutputAdapter;
     });
 
     it('should sort the empty list', () => {
@@ -413,7 +413,7 @@ class CountriesInputAdapterStub {
     let countryList;
 
     beforeEach(async () => {
-      countryList = await CountryList.create_instance(CountriesInputAdapterStub, new MockCountriesOutputAdapter());
+      countryList = await CountryList.create_instance(CountriesInputAdapterStub, MockCountriesOutputAdapter);
     });
 
 
@@ -467,7 +467,7 @@ as in addition to `fs.writeFile()` there is a
 
 ```javascript
 class CsvOutputAdapter {
-  write(countrList) {
+  static write(countrList) {
     let csvContent = "";
 
     countrList.forEach(function (rowArray) {
@@ -493,7 +493,7 @@ that is normally written to a (CSV) file.
 ```javascript
 
 class MockCountriesOutputAdapter {
-  write(countrList) {
+  static write(countrList) {
     let csvContent = "";
 
     countrList.forEach(function(rowArray) {