Ip pool crd #11
Open
Ip pool crd #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the stale IPPool in NCP, use v1alpha2.
Consider the below scenarios: * When a new added pod whose port name exists in security policy * When a deleted pod whose port name exists in security policy * When a pod's label is changed * When a namespace's label is changed Ensure named port and endPort not coexist, endPort can only be defined if port is also defined, and both ports must be numeric. Fix compare rule and compare group logic. When pod or namespace label change, the IPSet group may change, however, the groups compare logic still returns equal, the group misses Expression field and should also use DataValueToJsonEncoder to compare groups. Fix the bug no pod to be selected if only namespaceSelectors or podSelector. Fix the bug no right pod to be selected when there is *and* relationship in one target and *or* relationship in another target.
…rt-new3 Support named port feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.