Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action #259

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add action #259

merged 1 commit into from
Jul 24, 2024

Conversation

vorosl
Copy link
Contributor

@vorosl vorosl commented Jul 18, 2024

Add action for testing sljit on different architectures

@zherczeg
Copy link
Owner

Please give a better description for this patch

@vorosl vorosl force-pushed the ci branch 13 times, most recently from 0ff9e96 to b18af71 Compare July 19, 2024 10:35
@vorosl vorosl changed the title [WIP] Add action Add action Jul 19, 2024
@vorosl vorosl force-pushed the ci branch 3 times, most recently from 1a3904c to 799b903 Compare July 19, 2024 10:50
@lrzlin
Copy link
Contributor

lrzlin commented Jul 20, 2024

Seems that this patch is using qemu-user, in that case maybe we could add loong64 CI support to sljit?

Edit:
I wrote the loongarch64 one, tested under ubuntu, which should be fine, could you please add this into your PR? Otherwise I'll add a seperate PR, I do think sljit really needs CI for maintainability.

build-test-on-loongarch64:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v4
      with:
        submodules: true
    - name: Install compiler
      run: |
          sudo apt update
          sudo apt install -y make wget ninja-build
          wget https://github.com/loongson/build-tools/releases/download/2024.06.01/x86_64-cross-tools-loongarch64-binutils_2.42-gcc_14.1.0-glibc_2.39.tar.xz
          tar -xvf x86_64-cross-tools-loongarch64-binutils_2.42-gcc_14.1.0-glibc_2.39.tar.xz
    - name: Install qemu
      run: |
          wget https://download.qemu.org/qemu-9.0.2.tar.xz
          tar -xvf qemu-9.0.2.tar.xz
          cd qemu-9.0.2
          ./configure --target-list="loongarch64-linux-user"
          make -j4
    - name: Build and test
      env:
        CROSS_COMPILER: ./cross-tools/bin/loongarch64-unknown-linux-gnu-gcc
        CFLAGS: -march=la464
        EXTRA_LDFLAGS: -static
      run: |
        make all
        ./qemu-9.0.2/build/qemu-loongarch64 ./bin/sljit_test -v

@vorosl vorosl force-pushed the ci branch 3 times, most recently from 4daf9f7 to e0ec52d Compare July 22, 2024 09:53
@vorosl
Copy link
Contributor Author

vorosl commented Jul 22, 2024

Seems that this patch is using qemu-user, in that case maybe we could add loong64 CI support to sljit?

Edit: I wrote the loongarch64 one, tested under ubuntu, which should be fine, could you please add this into your PR? Otherwise I'll add a seperate PR, I do think sljit really needs CI for maintainability.

build-test-on-loongarch64:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v4
      with:
        submodules: true
    - name: Install compiler
      run: |
          sudo apt update
          sudo apt install -y make wget ninja-build
          wget https://github.com/loongson/build-tools/releases/download/2024.06.01/x86_64-cross-tools-loongarch64-binutils_2.42-gcc_14.1.0-glibc_2.39.tar.xz
          tar -xvf x86_64-cross-tools-loongarch64-binutils_2.42-gcc_14.1.0-glibc_2.39.tar.xz
    - name: Install qemu
      run: |
          wget https://download.qemu.org/qemu-9.0.2.tar.xz
          tar -xvf qemu-9.0.2.tar.xz
          cd qemu-9.0.2
          ./configure --target-list="loongarch64-linux-user"
          make -j4
    - name: Build and test
      env:
        CROSS_COMPILER: ./cross-tools/bin/loongarch64-unknown-linux-gnu-gcc
        CFLAGS: -march=la464
        EXTRA_LDFLAGS: -static
      run: |
        make all
        ./qemu-9.0.2/build/qemu-loongarch64 ./bin/sljit_test -v

@lrzlin Thank you very much your CI script, I've inserted it into my PR.

@vorosl vorosl force-pushed the ci branch 2 times, most recently from 9b4dbec to 381aa48 Compare July 22, 2024 10:23
Add action for testing sljit on different architectures
Copy link
Owner

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 8831185 into zherczeg:master Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants