Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loongarch: Optimize jump maximum offset prediction & update action co… #273

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

lrzlin
Copy link
Contributor

@lrzlin lrzlin commented Nov 2, 2024

Optimize LoongArch jump maximum offset prediction just like RISC-V and replace the out-dated compiler link used in github actions. Tested on 3A6000.

Done: #272 (comment)

@zherczeg
Copy link
Owner

zherczeg commented Nov 3, 2024

The patch is ok, thank you!

@carenas the CI says things like:
ERROR: failed to solve: arm32v7/ubuntu:latest: failed to resolve source metadata for docker.io/arm32v7/ubuntu:latest: no match for platform in manifest: not found
make: ./cross-tools/bin/loongarch64-unknown-linux-gnu-gcc-14.1.0: No such file or directory

Do you have an idea what is happening?

@carenas
Copy link
Contributor

carenas commented Nov 3, 2024

The loongarch specific issue should be fixed by using the correct gcc binary from the new bundle as shown by fbbc169

But seems that the code is broken as shown by:

https://github.com/carenas/sljit/actions/runs/11657904790/job/32456170441

@lrzlin
Copy link
Contributor Author

lrzlin commented Nov 5, 2024

@zherczeg Sorry for the late fix, my email accidently put github notification into trashbin. I've fix the code & loongarch64 CI.

@carenas Thanks for your correction!

Copy link
Owner

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 446e5c7 into zherczeg:master Nov 5, 2024
7 of 11 checks passed
@zherczeg
Copy link
Owner

zherczeg commented Nov 5, 2024

Thank you for the quick update

@lrzlin lrzlin deleted the loong-optimize branch November 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants