Update to build with recent Rust and benchmark point range queries #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses the low-hanging fruit:
1. Update rust-toolchain to a recent nightly.
2. Remove feature flags for invalid features.
3. Update feature usage (mostly MaybeUnInit::get_{ref,mut} and
Vec::drain_filter.
We still have 12 compiler errors, mostly around casting &T to &mut T, but I wanted to clean up some warnings to reduce noise.
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Added new example with points and benchmarking
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! A couple of us (myself and @harshavamsi) were looking into Lucene's range query performance and wanted to compare against other implementations, including Rucene and Tantivy.
In order to get Rucene compiling with modern Rust, we had to make a number of changes, mostly around names of things (e.g.
get_{ref,mut}becameassume_init_{ref,mut}forMaybeUninit), but also we had to fix a bunch of "undefined behavior" errors related to interior mutability.This PR also contains the range query benchmark harness that we built for our experiment (plus a flamegraph from profiling Rucene on those benchmarks). We can remove those from this PR if needed. I just wanted to make sure to surface the build fixes that we've done in case they help someone else.