address comments

zhli1142015 · Jan 3, 2025 · c8a3e1e · c8a3e1e
1 parent 15a4e70
commit c8a3e1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/velox/docs/functions/spark/datetime.rst b/velox/docs/functions/spark/datetime.rst
@@ -129,7 +129,7 @@ These functions support TIMESTAMP and DATE input types.
 
     Returns the date from year, month and day fields.
     ``year``, ``month`` and ``day`` must be ``INTEGER``.
-    Returns NULL if inputs are not valid. (ANSI mode is off by default.)
+    Returns NULL if inputs are not valid.
 
     The valid inputs need to meet the following conditions,
     ``month`` need to be from 1 (January) to 12 (December).

diff --git a/velox/functions/sparksql/DateTimeFunctions.h b/velox/functions/sparksql/DateTimeFunctions.h
@@ -459,7 +459,7 @@ struct MakeDateFunction {
       return false;
     }
     int64_t daysSinceEpoch = expected.value();
-    if (daysSinceEpoch != (int32_t)daysSinceEpoch) {
+    if (daysSinceEpoch != static_cast<int32_t>(daysSinceEpoch)) {
       return false;
     }
     result = daysSinceEpoch;