Fix GCC12 return-type warning (facebookincubator#9902)

Summary: Fix warnings of type `control reaches end of non-void function [-Wreturn-type]` Pull Request resolved: facebookincubator#9902 Reviewed By: amitkdutta, tanjialiang Differential Revision: D57847046 Pulled By: xiaoxmeng fbshipit-source-id: 2ed27af9027da729bb7a156ed05107fcfbfd3145
zhli1142015 · May 28, 2024 · cbf9b55 · cbf9b55
1 parent ba98319
commit cbf9b55
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/velox/functions/lib/aggregates/BitwiseAggregateBase.h b/velox/functions/lib/aggregates/BitwiseAggregateBase.h
@@ -108,8 +108,7 @@ exec::AggregateRegistrationResult registerBitwise(
           case TypeKind::BIGINT:
             return std::make_unique<T<int64_t>>(resultType);
           default:
-            VELOX_CHECK(
-                false,
+            VELOX_UNREACHABLE(
                 "Unknown input type for {} aggregation {}",
                 name,
                 inputType->kindName());

diff --git a/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp b/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
@@ -971,10 +971,9 @@ exec::AggregateRegistrationResult registerMinMax(
               if (inputType->isLongDecimal()) {
                 return std::make_unique<TNumericN<int128_t>>(resultType);
               }
-              VELOX_UNREACHABLE();
+              [[fallthrough]];
             default:
-              VELOX_CHECK(
-                  false,
+              VELOX_UNREACHABLE(
                   "Unknown input type for {} aggregation {}",
                   name,
                   inputType->kindName());
@@ -1012,8 +1011,7 @@ exec::AggregateRegistrationResult registerMinMax(
               return std::make_unique<TNonNumeric>(
                   inputType, throwOnNestedNulls);
             default:
-              VELOX_CHECK(
-                  false,
+              VELOX_UNREACHABLE(
                   "Unknown input type for {} aggregation {}",
                   name,
                   inputType->kindName());

diff --git a/velox/functions/prestosql/aggregates/SumAggregate.cpp b/velox/functions/prestosql/aggregates/SumAggregate.cpp
@@ -104,8 +104,7 @@ exec::AggregateRegistrationResult registerSum(
             return std::make_unique<DecimalSumAggregate<int128_t>>(resultType);
 
           default:
-            VELOX_CHECK(
-                false,
+            VELOX_UNREACHABLE(
                 "Unknown input type for {} aggregation {}",
                 name,
                 inputType->kindName());

diff --git a/velox/functions/sparksql/aggregates/SumAggregate.cpp b/velox/functions/sparksql/aggregates/SumAggregate.cpp
@@ -148,8 +148,7 @@ exec::AggregateRegistrationResult registerSum(
           }
             [[fallthrough]];
           default:
-            VELOX_CHECK(
-                false,
+            VELOX_UNREACHABLE(
                 "Unknown input type for {} aggregation {}",
                 name,
                 inputType->kindName());