Skip to content

Commit

Permalink
Dev: Removed support for editable installs
Browse files Browse the repository at this point in the history
Signed-off-by: Andreas Maier <[email protected]>
  • Loading branch information
andy-maier committed Jul 29, 2024
1 parent b975780 commit 7499fbd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,14 @@ done_dir := done
# Packages whose dependencies are checked using pip-missing-reqs
ifeq ($(python_version),3.6)
check_reqs_packages := pip_check_reqs pipdeptree build pytest coverage coveralls flake8 pylint twine
run_check_reqs_install := false
else
ifeq ($(python_version),3.7)
check_reqs_packages := pip_check_reqs pipdeptree build pytest coverage coveralls flake8 pylint twine safety
run_check_reqs_install := false
else
check_reqs_packages := pip_check_reqs pipdeptree build pytest coverage coveralls flake8 pylint twine safety sphinx
run_check_reqs_install := true
endif
endif

Expand Down Expand Up @@ -254,10 +257,12 @@ safety: $(done_dir)/safety_all_$(pymn)_$(PACKAGE_LEVEL).done $(done_dir)/safety_

.PHONY: check_reqs
check_reqs: $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done minimum-constraints.txt minimum-constraints-install.txt requirements.txt
ifeq ($(run_check_reqs_install),true)
@echo "Makefile: Checking missing dependencies of this package"
pip-missing-reqs $(package_name) --requirements-file=requirements.txt
pip-missing-reqs $(package_name) --requirements-file=minimum-constraints-install.txt
@echo "Makefile: Done checking missing dependencies of this package"
endif
ifeq ($(PLATFORM),Windows_native)
# Reason for skipping on Windows is https://github.com/r1chardj0n3s/pip-check-reqs/issues/67
@echo "Makefile: Warning: Skipping the checking of missing dependencies of site-packages directory on native Windows" >&2
Expand Down Expand Up @@ -361,10 +366,10 @@ $(done_dir)/install_base_$(pymn)_$(PACKAGE_LEVEL).done: minimum-constraints.txt
@echo "Makefile: Done installing base packages"
echo "done" >$@

$(done_dir)/install_$(pymn)_$(PACKAGE_LEVEL).done: $(done_dir)/install_base_$(pymn)_$(PACKAGE_LEVEL).done requirements.txt minimum-constraints.txt minimum-constraints-install.txt setup.py
$(done_dir)/install_$(pymn)_$(PACKAGE_LEVEL).done: $(done_dir)/install_base_$(pymn)_$(PACKAGE_LEVEL).done requirements.txt minimum-constraints.txt minimum-constraints-install.txt setup.py $(package_py_files)
@echo "Makefile: Installing package and its prerequisites with PACKAGE_LEVEL=$(PACKAGE_LEVEL)"
-$(call RM_FUNC,$@)
$(PYTHON_CMD) -m pip install $(pip_level_opts) -e .
$(PYTHON_CMD) -m pip install $(pip_level_opts) .
@echo "Makefile: Done installing package and its prerequisites"
echo "done" >$@

Expand Down
3 changes: 3 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Released: not yet
* Removed lengthy display of URI to resource cache when ignoring labels due to
Jinja2 error.

* Dev: Removed support for editable installs, because pip 25 will disable that.
(issue #546)

**Known issues:**

* See `list of open issues`_.
Expand Down

0 comments on commit 7499fbd

Please sign in to comment.