forked from pytorch/pytorch
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ExecuTorch pinned commit update failure (pytorch#117518)
pytorch#117003 shows in interesting failure in which building ExecuTorch runner fails because it needs the change from pytorch#117378. This reveals a chicken-and-egg bug in the job setup where building ExecuTorch runner depends on PyTorch and thus couldn't be part of the Docker image build where PyTorch is not yet available. The failure happens because an outdated version of PyTorch is there on the Docker image. So, like vision and audio, the step to build ExecuTorch runner needs to be done during test time. I also fix the installation of vision and audio in ET job because they are now installed using PyTorch pinned commits as usual after pytorch/executorch#1247 Pull Request resolved: pytorch#117518 Approved by: https://github.com/larryliu0820, https://github.com/malfet
- Loading branch information
1 parent
c30346d
commit 99e5474
Showing
3 changed files
with
10 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
663882fe7dc518c04adf3d2ee5ccb7d99f41ade4 | ||
2d39c223f23fbd6cc063e06f3374cb107e229a31 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters