Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set external temperature in Aqara E1 thermostat #3452

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

morus12
Copy link

@morus12 morus12 commented Oct 22, 2024

Proposed change

Additional information

This PR adds:

  • option to set external or internal temperature sensor
  • option to set temperature from external sensor
Screenshot 2024-10-23 at 00 24 51 Screenshot 2024-10-23 at 00 26 32

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (c788758) to head (677e67b).
Report is 51 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/xiaomi/aqara/thermostat_agl001.py 79.54% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3452   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files         309      311    +2     
  Lines       10006    10077   +71     
=======================================
+ Hits         8945     9009   +64     
- Misses       1061     1068    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Xiaomi Request/PR regarding a Xiaomi device label Oct 23, 2024
@MrDodojo
Copy link

I tried this but i'm not getting it to work, would you like to debug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Xiaomi Request/PR regarding a Xiaomi device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants