Convert Tuya sirens to v2 quirks #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3741 +/- ##
==========================================
+ Coverage 90.04% 90.08% +0.04%
==========================================
Files 321 320 -1
Lines 10442 10415 -27
==========================================
- Hits 9402 9382 -20
+ Misses 1040 1033 -7 ☔ View full report in Codecov by Sentry. |
zhaquirks/tuya/tuya_siren.py
Outdated
Comment on lines
211
to
217
| .tuya_enum( | ||
| dp_id=101, | ||
| attribute_name="power_type", | ||
| enum_class=NeoBatteryState, | ||
| translation_key="power_type", | ||
| fallback_name="Power type", | ||
| ) |
There was a problem hiding this comment.
Should this be a sensor?
There was a problem hiding this comment.
Yes, it should be.
There was a problem hiding this comment.
f5b13d8 should address this.
TheJulianJES
added
the
needs review
TheJulianJES
approved these changes
Jan 21, 2025
TheJulianJES
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This converts the existing Tuya sirens to v2 and add some additional ones.
_TZE200_d0yu2xgi Based on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/f42aa5080ee933e8cde9fc08c67a88bf886d71ff/src/devices/neo.ts#L13
_TZE200_t1blo2bj, _TZE204_t1blo2bj, and _TZE204_q76rtoa9 Based on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/f42aa5080ee933e8cde9fc08c67a88bf886d71ff/src/devices/neo.ts#L48C91-L48C107
_TZE204_hcxvyxa5 Based on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/f42aa5080ee933e8cde9fc08c67a88bf886d71ff/src/devices/tuya.ts#L12753
_TZE204_fncxk3ob and CBased on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/f42aa5080ee933e8cde9fc08c67a88bf886d71ff/src/devices/tuya.ts#L10621C51-L10621C67
Additional information
Closes: #2300
Closes: #3180
Closes: #3545
Checklist
pre-commitchecks pass / the code has been formatted using Black