-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zig AstGen changes, unnecessary use of 'var' #1605
Conversation
d7403cb
to
d811e00
Compare
Our dependencies will also need to be updated:
|
That gist has changed hands as many times as it's been updated, you have the choice of converting in to a repo. |
@SuperAuguste Can I create this as a new repository in zigtools? |
sure @Techatrix! tbh I don't believe there's a lot of external interest in using the binned allocator so you could also just plop it in a file in the zls repo :P |
I guess that would also work. I though there were other project that also used the binned allocator but sourcegraph search couldn't find any. @nullptrdevs Would you mind If I added the binned allocator in your PR directly? |
Go ahead, and always feel free to make changes/push commits to any of my PRs ! I always |
- fix data race when allocating with thread safety - remove workarounds for ziglang/zig#14705 - correct unnecessary uses of 'var' Note that the BSD Zero Clause License has been removed from binned_allocator.zig
Co-authored-by: Ian Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; took it for a spin on ZLS for a bit and didn't encounter any crashes or anything :) (every PR I merge without fuzzing reminds me that I should really finish that code :/)
This can be merged as-is, or we can wait and see if I missed changing a
var
toconst
somewhere.