Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous zig std api breaking fix #1620

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Miscellaneous zig std api breaking fix #1620

merged 6 commits into from
Nov 26, 2023

Conversation

jimying
Copy link
Contributor

@jimying jimying commented Nov 23, 2023

Fix zig std api breaking list:

ps: this change need set minimum zig build version to 0.12.0-dev.1686+d5e21a4f1
@jimying jimying changed the title zig std had removed meta.trait Miscellaneous breaking fix Nov 23, 2023
@jimying jimying changed the title Miscellaneous breaking fix Miscellaneous zig std api breaking fix Nov 23, 2023
Copy link
Contributor

@llogick llogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llogick llogick linked an issue Nov 24, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d433a58) 73.79% compared to head (eacb199) 73.77%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/features/completions.zig 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
- Coverage   73.79%   73.77%   -0.02%     
==========================================
  Files          33       33              
  Lines        8974     8981       +7     
==========================================
+ Hits         6622     6626       +4     
- Misses       2352     2355       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llogick
Copy link
Contributor

llogick commented Nov 24, 2023

/home/runner/.cache/zig/p/1220f9d9dd88b1352b1a2bde4a96f547a1591d66ad0a9d76854d0c2c7fa59eef2508/known-folders.zig:66:44: error: root struct of file 'os.windows' has no member named 'shell32'

Any Windows users willing to do a PR?

@SuperAuguste
Copy link
Member

ziglibs/known-folders#42 :)

Copy link
Contributor

@llogick llogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@llogick llogick merged commit a0affc7 into zigtools:master Nov 26, 2023
4 of 6 checks passed
@jimying jimying deleted the no-trait branch November 27, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with latest zig build
4 participants