-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous zig std api breaking fix #1620
Conversation
ps: this change need set minimum zig build version to 0.12.0-dev.1686+d5e21a4f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to test that it builds with -Doptimize=ReleaseSafe
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 73.79% 73.77% -0.02%
==========================================
Files 33 33
Lines 8974 8981 +7
==========================================
+ Hits 6622 6626 +4
- Misses 2352 2355 +3 ☔ View full report in Codecov by Sentry. |
Any Windows users willing to do a PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
Fix zig std api breaking list:
ziglang/zig@d5e21a4
std: remove meta.trait ziglang/zig#18061
std.fs: split
Dir
intoIterableDir
ziglang/zig#12060rework std.atomic ziglang/zig#18085