Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.py #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update main.py #10

wants to merge 1 commit into from

Conversation

LiyuanLucasLiu
Copy link

the current version of --cuda is store_false, maybe it would be better to change it

@LiyuanLucasLiu
Update main.py
5dff6c4 
the current version of ``--cuda`` is store_false, maybe it would be better to change it
@kimiyoung
Copy link
Collaborator

How about
parser.add_argument('--nocuda', action='store_false', dest='cuda', default=True)

@LiyuanLucasLiu
Copy link
Author

I think the default setting should be using cuda, is that right?
Personally I prefer 'store_true'. And in the pull request, I also modified two parts..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiyuanLucasLiu @kimiyoung