-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DAAT MaxScore support for sparse vector #1015
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sparknack The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sparknack 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
d97ecce
to
c8541a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=========================================
+ Coverage 0 74.08% +74.08%
=========================================
Files 0 82 +82
Lines 0 7042 +7042
=========================================
+ Hits 0 5217 +5217
- Misses 0 1825 +1825 |
bea6a0b
to
6ad147f
Compare
@@ -34,6 +34,13 @@ | |||
#include "knowhere/utils.h" | |||
|
|||
namespace knowhere::sparse { | |||
|
|||
enum InvertedIndexAlgo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend to use enum class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
include/knowhere/utils.h
Outdated
template <typename R> | ||
static void | ||
readBinaryString(R& in, std::string& str) { | ||
in.read((char*)str.data(), str.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A size field should be reserved, and the size should be written first, and then the data; deserialization corresponds to it; it is easy to make mistakes if you rely on the size of the input string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code has been removed since we want to redesign the file header later.
6ad147f
to
7a67eda
Compare
fbb19ae
to
5ad6bde
Compare
Signed-off-by: Shawn Wang <[email protected]>
…ntroduced Signed-off-by: Shawn Wang <[email protected]>
5ad6bde
to
7f5f76e
Compare
use_wand
and introduce a newenum InvertedIndexAlgo
to support different search algorithm.