Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse: reduce ut execution time #1041

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

sparknack
Copy link
Contributor

Reduce ut execution time, which is from 532.62 secs to 46.50 secs on my machine.

Reduce ut execution time, which is from 532.62 secs to 46.50 secs on my
machine.

Signed-off-by: Shawn Wang <[email protected]>
@sparknack
Copy link
Contributor Author

issue: #1039

Copy link

mergify bot commented Jan 17, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.01%. Comparing base (3c46f4c) to head (9b09fc2).
Report is 297 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1041       +/-   ##
=========================================
+ Coverage      0   73.01%   +73.01%     
=========================================
  Files         0       82       +82     
  Lines         0     7507     +7507     
=========================================
+ Hits          0     5481     +5481     
- Misses        0     2026     +2026     

see 82 files with indirect coverage changes

@alexanderguzhva
Copy link
Collaborator

@sparknack is it needed to run 2000 vectors if we have 3000?

@sparknack
Copy link
Contributor Author

@sparknack is it needed to run 2000 vectors if we have 3000?

3000 is the vector dimension, not the total number of the vectors.

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, sparknack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator

foxspy commented Jan 20, 2025

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 0aa91b4 into zilliztech:main Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants