Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DiskANN Hybrid Search via Alpha-Strategy #143

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

PwzXxm
Copy link
Collaborator

@PwzXxm PwzXxm commented Oct 12, 2023

issue: #142
/kind enhancement

This PR contains:

  1. Implement alpha-strategy in DiskANN cached_beam_search, which makes at most 6x QPS improvements, 87% recall at filter rate 90%.
  2. Only compute PQ distances for unvisited/unfiltered neighbors instead of all neighbors. This yields around 16% and 34% improvements in QPS on Cohere 1M and OpenAI 1M on the test machine. This result might not be convincing as Milvus might not be stable at the time of the test. Might need to investigation further.
  3. Remove the dynamic threshold and fix it to 0.93 as HNSW.

The Milvus E2E performance is shown below.

image

Note that in the above figure, the recall at the filter rate of 95% does not match with the code, only for experimental purposes.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@alwayslove2013 alwayslove2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6ed164e into zilliztech:main Oct 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants