Remove diskann pramaters check in diskann.cc #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cqy123456 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Signed-off-by: cqy123456 <[email protected]>
cqy123456
force-pushed
the
diskann-params-range-update
branch
from
94fc1db to
54b502c
Compare
|
/run-e2e |
|
/rerun-e2e |
|
/kind improvement |
foxspy
pushed a commit
to foxspy/knowhere
that referenced
this pull request
Dec 7, 2023
…h#51) * Use new cardinal hnsw and diskann config to relax checking Signed-off-by: chasingegg <[email protected]> * remove diskann pramaters check (zilliztech#169) Signed-off-by: cqy123456 <[email protected]> --------- Signed-off-by: chasingegg <[email protected]> Signed-off-by: cqy123456 <[email protected]> Co-authored-by: cqy123456 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #196