Add iterator support to pyknowhere interface. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Buqian Zheng <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cydrain
reviewed
Nov 14, 2023
python/knowhere/knowhere.i
Outdated
| @@ -113,6 +115,25 @@ public: | |||
| PyThreadState* save; | |||
| }; | |||
|
|
|||
| class AnnIterator { | |||
There was a problem hiding this comment.
Suggest to rename to "IteratorWrap"
cydrain
reviewed
Nov 14, 2023
| @@ -157,6 +178,22 @@ class IndexWrap { | |||
| } | |||
| } | |||
|
|
|||
| std::vector<AnnIterator> | |||
| GetAnnIterator(knowhere::DataSetPtr dataset, const std::string& json, const knowhere::BitsetView& bitset, knowhere::Status& status) { | |||
There was a problem hiding this comment.
Keeping keyword Ann as discussed.
Signed-off-by: Buqian Zheng <[email protected]>
cydrain
reviewed
Nov 22, 2023
| @@ -113,6 +115,25 @@ public: | |||
| PyThreadState* save; | |||
| }; | |||
|
|
|||
| class AnnIteratorWrap { | |||
| public: | |||
| AnnIteratorWrap(std::shared_ptr<IndexNode::iterator> it = nullptr) : it_(it) { | |||
There was a problem hiding this comment.
suggest to assert here if it is NULL
Signed-off-by: Buqian Zheng <[email protected]>
buqian-zilliz
force-pushed
the
pyknowhere-it
branch
from
338f3f5 to
5352241
Compare
|
/lgtm |
cydrain
added a commit
to cydrain/knowhere
that referenced
this pull request
Dec 5, 2023
Correct bitset support in pyknowhere (zilliztech#165) Add new interface for brute force search and simd test in pyknowhere (zilliztech#170) Add iterator support to pyknowhere interface. (zilliztech#189) Use knowhere-test refactor (zilliztech#217) Signed-off-by: Yudong Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GetAnnIterator method to the swigknowhere IndexWrap class to wrap the AnnIterator method, so iterator can also be used in pyknowhere.
/kind improvement