Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [skip e2e]update e2e-gpu builder image #197

Merged
merged 1 commit into from
Nov 17, 2023
Merged

enhance: [skip e2e]update e2e-gpu builder image #197

merged 1 commit into from
Nov 17, 2023

Conversation

yellow-shine
Copy link
Collaborator

No description provided.

@sre-ci-robot
Copy link
Collaborator

Welcome @samhuang-z! It looks like this is your first PR to zilliztech/knowhere 🎉

@yellow-shine yellow-shine changed the title enhance: update e2e-gpu builder image enhance: [skip e2e]update e2e-gpu builder image Nov 16, 2023
@mergify Mergify
Copy link

mergify bot commented Nov 16, 2023

@samhuang-z 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mergify mergify bot added the ci-passed label Nov 16, 2023
@yellow-shine
Copy link
Collaborator Author

/kind improvement

1 similar comment
@Bennu-Li
Copy link
Contributor

/kind improvement

@mergify Mergify
Copy link

mergify bot commented Nov 17, 2023

@samhuang-z Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

@Bennu-Li
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bennu-Li, Presburger, samhuang-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 26be1ed into zilliztech:main Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bennu-Li Bennu-Li Bennu-Li approved these changes

@Presburger Presburger Presburger approved these changes

@hhy3 hhy3 Awaiting requested review from hhy3

Assignees

@Bennu-Li Bennu-Li

Labels
approved ci-passed dco-passed kind/improvement lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yellow-shine @sre-ci-robot @Bennu-Li @Presburger