Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gen_fbin_file.cpp to support binary data type #211

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Nov 23, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Nov 23, 2023

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain
Copy link
Collaborator Author

cydrain commented Nov 23, 2023

/kind improvement

benchmark/hdf5/gen_fbin_file.cpp Outdated Show resolved Hide resolved
@cydrain cydrain force-pushed the caiyd_update_gen_fbin branch from 2b7640a to 3044ca8 Compare November 24, 2023 02:34
@mergify mergify bot added ci-passed and removed ci-passed labels Nov 24, 2023
@zhengbuqian
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 439a0dd into zilliztech:main Nov 24, 2023
7 checks passed
@cydrain cydrain deleted the caiyd_update_gen_fbin branch November 24, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants