Update folly to resolve simd issue #242
Conversation
|
@chasingegg 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
/run-e2e |
|
/lgtm |
|
/run-e2e |
1 similar comment
|
/run-e2e |
chasingegg
force-pushed
the
update-folly
branch
from
6627e83 to
7e87610
Compare
conanfile.py
Outdated
| @@ -91,7 +91,8 @@ def requirements(self): | |||
| self.requires("double-conversion/3.2.1") | |||
| self.requires("xz_utils/5.2.5") | |||
| self.requires("fmt/9.1.0") | |||
| self.requires("folly/2023.07.12@milvus/dev") | |||
| self.requires("folly/2023.10.30.04@milvus/dev") | |||
| self.requires("libunwind/1.7.2") | |||
There was a problem hiding this comment.
MacOS cannot use libunwind, refer this PR milvus-io/milvus#28929
Signed-off-by: chasingegg <[email protected]>
chasingegg
force-pushed
the
update-folly
branch
from
7e87610 to
4e55c19
Compare
|
/lgtm |
|
@jiaoew1991: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind improvement |
mergify
bot
added
do-not-merge/description-tag-conflict
and removed
do-not-merge/missing-related-issue
labels
|
@chasingegg Please remove redundant |
related milvus issue milvus-io/milvus#27552
milvus fix milvus-io/milvus#28878
/kind bug