Remove search_list_and_k_ratio param #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_list_and_k_ratio
is useless, since in range search we will perform iterative search each time we will enlarge topk. We don't needsearch_list_and_k_ratio
to make search_list larger than topk, once we search by search_list in an iteration, we could get all results to verify, not just choosing topk of them. Therefore we only need min_k and max_k to control the range search./kind improvement