Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add a bit-based structure to mark index-specific features #887

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Oct 14, 2024

issue: #795
/kind improvement

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (3c46f4c) to head (e54d76a).
Report is 219 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #887       +/-   ##
=========================================
+ Coverage      0   77.65%   +77.65%     
=========================================
  Files         0       85       +85     
  Lines         0     6377     +6377     
=========================================
+ Hits          0     4952     +4952     
- Misses        0     1425     +1425     

see 85 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 14, 2024
include/knowhere/feature.h Show resolved Hide resolved
include/knowhere/feature.h Show resolved Hide resolved
include/knowhere/index/index_factory.h Show resolved Hide resolved
include/knowhere/index/index_factory.h Outdated Show resolved Hide resolved
include/knowhere/index/index_factory.h Show resolved Hide resolved
@foxspy foxspy force-pushed the add_vector_index_feature branch from 0e54a76 to 0ec434d Compare October 15, 2024 03:17
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 15, 2024
@foxspy foxspy force-pushed the add_vector_index_feature branch from 0ec434d to e54d76a Compare October 15, 2024 09:29
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 15, 2024
@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 183a128 into zilliztech:main Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants