Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance : update vector index defeault value #946

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Nov 14, 2024

issue : milvus-io/milvus#36906
Discussed with product manager, we need give default value for most index params. The document will be updated together

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy foxspy changed the title enhance : update knowhere defeault value enhance : update vector index defeault value Nov 14, 2024
Copy link

mergify bot commented Nov 14, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (3c46f4c) to head (3cde26b).
Report is 251 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #946       +/-   ##
=========================================
+ Coverage      0   74.29%   +74.29%     
=========================================
  Files         0       82       +82     
  Lines         0     6644     +6644     
=========================================
+ Hits          0     4936     +4936     
- Misses        0     1708     +1708     

see 82 files with indirect coverage changes

@foxspy
Copy link
Collaborator Author

foxspy commented Nov 14, 2024

/kind improvement

@chasingegg
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit bdb98cb into zilliztech:main Nov 14, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants