Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Isolate faiss_hnsw and hnsw by index version #952

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Nov 16, 2024

issue: milvus-io/milvus#37665
Considering the compatibility during the distributed system upgrade, faiss_hnsw and hnswlib must be isolated by version on both the read and write path; for version <= 5, these indexes will be processed by hnswlib; otherwise, they will be processed by faiss; the maximum availability of index version during the upgrade process has been guaranteed in the early stage

Copy link

mergify bot commented Nov 16, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator Author

foxspy commented Nov 16, 2024

/kind improvement

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 98253b8 into zilliztech:main Nov 16, 2024
10 of 11 checks passed
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (3c46f4c) to head (6a9d61e).
Report is 255 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #952       +/-   ##
=========================================
+ Coverage      0   74.36%   +74.36%     
=========================================
  Files         0       82       +82     
  Lines         0     6682     +6682     
=========================================
+ Hits          0     4969     +4969     
- Misses        0     1713     +1713     

see 82 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants