Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: pick prs from main for knowhere v2.3.13 #955

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Nov 18, 2024

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Nov 18, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy foxspy changed the title enhance: pick prs from master for knowhere v2.3.13 enhance: pick prs from main for knowhere v2.3.13 Nov 18, 2024
Presburger and others added 13 commits November 18, 2024 13:04
Signed-off-by: yusheng.ma <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
Add SparseInvertedIndexNodeCC to allow being thread safe growing index

Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
* sparse: make the distance returned by RangeSearch and AnnIterator to be the raw instead of the quantized distance

Signed-off-by: Buqian Zheng <[email protected]>

* sparse: remove mutex in the index: we now use CC index if concurrent read/write is needed

Signed-off-by: Buqian Zheng <[email protected]>

---------

Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
Added the PowerPC vector functions in src/simd/distances_powerpc.cc,
src/simd/distances_powerpc.h.  The hooks to the PowerPC functions are
added in src/simd/hook.cc.

Signed-off-by: Carl Love <[email protected]>
Co-authored-by: Carl Love <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
@foxspy
Copy link
Collaborator Author

foxspy commented Nov 18, 2024

/kind improvement

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.4@eff590a). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.4     #955   +/-   ##
======================================
  Coverage       ?   79.19%           
======================================
  Files          ?       81           
  Lines          ?     6581           
  Branches       ?        0           
======================================
  Hits           ?     5212           
  Misses         ?     1369           
  Partials       ?        0           

@mergify mergify bot added the ci-passed label Nov 18, 2024
@zhengbuqian
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3c28949 into zilliztech:2.4 Nov 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants