-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix iterator: set omp to 1 #989
Conversation
@alwayslove2013 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
/kind improvement |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
=========================================
+ Coverage 0 73.84% +73.84%
=========================================
Files 0 82 +82
Lines 0 6916 +6916
=========================================
+ Hits 0 5107 +5107
- Misses 0 1809 +1809 |
85a3768
to
d38114d
Compare
d38114d
to
c89d181
Compare
/lgtm |
Generally e2e should finish in 30 minutes.
I cannot see "iterator_search runtime" in your e2e log, there must be something wrong |
Deadlock caused by nested calls to search thread pool. |
c89d181
to
0067c07
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: min.tian <[email protected]>
0067c07
to
64010b8
Compare
/hold |
@alwayslove2013 is it good to review this PR? thanks |
@alexanderguzhva Sorry, there are still some compatibility issues with bruteforce-iterator. I will fix it asap. please hold~ |
Use search_pool to handle iterator's next_batch instead of init